Skip to content

Schema exceptions refactor #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Oct 20, 2019

Fixes #160

@p1c2u p1c2u force-pushed the feature/schema-exceptions-refactor branch from 32f1624 to cfdf341 Compare October 20, 2019 14:06
@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.13%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage    96.4%   96.54%   +0.13%     
==========================================
  Files          67       67              
  Lines        1698     1706       +8     
==========================================
+ Hits         1637     1647      +10     
+ Misses         61       59       -2
Impacted Files Coverage Δ
openapi_core/schema/schemas/unmarshallers.py 100% <100%> (ø) ⬆️
openapi_core/schema/parameters/exceptions.py 85.18% <100%> (+1.18%) ⬆️
openapi_core/validation/response/validators.py 100% <100%> (ø) ⬆️
openapi_core/schema/media_types/models.py 90.24% <62.5%> (-4.36%) ⬇️
openapi_core/schema/schemas/exceptions.py 84.31% <72.41%> (+0.64%) ⬆️
openapi_core/schema/parameters/models.py 97.26% <75%> (ø) ⬆️
openapi_core/validation/request/validators.py 95.06% <90%> (+0.46%) ⬆️
openapi_core/schema/schemas/models.py 95.3% <91.66%> (+0.68%) ⬆️
openapi_core/schema/schemas/_validators.py 92.5% <0%> (-2.5%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd99117...cfdf341. Read the comment docs.

@p1c2u p1c2u merged commit 4c4636a into master Oct 20, 2019
@p1c2u p1c2u deleted the feature/schema-exceptions-refactor branch October 20, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.12.0 regression regarding usability of validation messages
1 participant