-
-
Notifications
You must be signed in to change notification settings - Fork 135
Fix #124: Checking "additionalProperties" in "oneOf" items. #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ems. This is important because it does the correct validation over items that are restricted in "oneOf", so that it's possible to use schemas that are superset of one another as items of "oneOf".
Oops, seems to have failed on Python 2.7 for some reason. I'll fix that. |
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 96.32% 96.05% -0.27%
==========================================
Files 54 54
Lines 1470 1472 +2
==========================================
- Hits 1416 1414 -2
- Misses 54 58 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 96.32% 96.33% +<.01%
==========================================
Files 54 54
Lines 1470 1474 +4
==========================================
+ Hits 1416 1420 +4
Misses 54 54
Continue to review full report at Codecov.
|
@diogobaeder thank you for the contribution. Made small refactor. LGTM |
Thanks, man! Since I'm still new to contributing, I didn't want to do too many changes... so thanks for refactoring it afterwards :-) |
Sorry for commenting here again, but is there any intention of releasing this fix soon? |
Fix python-openapi#124: Checking "additionalProperties" in "oneOf" items.
This is important because it does the correct validation over items that
are restricted in "oneOf", so that it's possible to use schemas that are
superset of one another as items of "oneOf".