Skip to content

Object additionalProperties support #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Object additionalProperties support #121

merged 2 commits into from
Mar 22, 2019

Conversation

ondratu
Copy link
Contributor

@ondratu ondratu commented Mar 12, 2019

  • Default is true like in specification
  • When is set false, it works like in past
  • Object with types works

It reslove Issue #67

* Default is true like in specification
* When is set false, it works like in past
* Object with types works
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #121 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   96.19%   96.19%   +<.01%     
==========================================
  Files          54       54              
  Lines        1444     1446       +2     
==========================================
+ Hits         1389     1391       +2     
  Misses         55       55
Impacted Files Coverage Δ
openapi_core/schema/schemas/models.py 94.26% <100%> (+0.03%) ⬆️
openapi_core/schema/schemas/factories.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395f68b...cfaeb03. Read the comment docs.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ondratu thank you for the contribution. Can you remove version change.

@ondratu
Copy link
Contributor Author

ondratu commented Mar 13, 2019

Done

@p1c2u p1c2u merged commit aa978cb into python-openapi:master Mar 22, 2019
bjmc pushed a commit to bjmc/openapi-core that referenced this pull request Jun 12, 2019
Object additionalProperties support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants