Properly formatting UUID if value to be unmarshalled is already a UUID. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if a UUID instance got received as value in the Schema, it was breaking the unmarshal because UUID instances can't be used as values to instantiate other UUIDs.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 96.3% 96.31% +0.01%
==========================================
Files 54 54
Lines 1462 1467 +5
==========================================
+ Hits 1408 1413 +5
Misses 54 54
Continue to review full report at Codecov.
|
|
Hi, Sorry to bother you, but any news on this one? I'm having to use Thanks, |
|
I'd love this to be merged, too! |
|
Hi, any news on this one? Sorry to bother, but I really need this change... |
|
Thanks man! :-) |
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
Properly formatting UUID if value to be unmarshalled is already a UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if a UUID instance got received as value in the Schema, it was breaking the unmarshal because UUID instances can't be used as values to instantiate other UUIDs.
An example of where this might happen is if you define a parameter with uuid format in a spec for a Flask app, and then use the
<uuid>converter in the route path (for the Flask router), which converts the parameter to a UUID instance before it reaches the unmarshalling step.