Accepting uuid string format and validating accordingly. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 96.18% 96.18% +<.01%
==========================================
Files 54 54
Lines 1441 1443 +2
==========================================
+ Hits 1386 1388 +2
Misses 55 55
Continue to review full report at Codecov.
|
|
@diogobaeder thank you for the contribution. Just need to cover that with tests. |
|
Nice, thanks for your additional commit! I just didn't know how to approach tests for specific validation, when I looked at the pet store tests, but now that you committed those it's clearer to me, thanks! Any chance to merge that soon, then? And to have a new release for it? |
|
New version should be released today |
|
Awesome! Thanks man :-) |
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
Accepting uuid string format and validating accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the compatibility with uuid formatted strings. Although it's not a predefined format in the standard, it's predicted as a possible custom format, so it makes sense to implement it since Python supports this as a type in the stdlib.