Revert PR 125 due to 1.17.0 breakage #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RonnyPfannschmidt
approved these changes
Jun 10, 2017
nicoddemus
force-pushed
the
revert-pr-125
branch
from
9578552 to
afe8bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the commits introduced by #125 because unfortunately it broke a number of test suites.
I think it is better to release a hot-fix reverting this while we investigate the issue better.
I tested this locally with pytest's own suite.
@RonnyPfannschmidt feel free to merge and make a new release if you agree.
cc @reginaldl
Fix #157