Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

enter_room and leave_room don't work #24

Closed
Roxe322 opened this issue Oct 28, 2021 · 2 comments
Closed

enter_room and leave_room don't work #24

Roxe322 opened this issue Oct 28, 2021 · 2 comments

Comments

@Roxe322
Copy link
Contributor

Roxe322 commented Oct 28, 2021

Hello! In #20 you added ability to join and leave rooms, but you made it as properties so when you call
sio.enter_room(sid, room)

it results to

TypeError: enter_room() missing 2 required positional arguments: 'sid' and 'room'

It should be not properties but methods.

@Roxe322
Copy link
Contributor Author

Roxe322 commented Oct 28, 2021

Otherwise, it could be just proxy-properties, without any params:

    @property
    def enter_room(self):
        return self._sio.enter_room

    @property
    def leave_room(self):
        return self._sio.leave_room

@Roxe322 Roxe322 changed the title enter_room and leave_room are properties instead of methods enter_room and leave_room don't work Oct 28, 2021
@Roxe322
Copy link
Contributor Author

Roxe322 commented Oct 28, 2021

So I made a pull request: #25

@pyropy pyropy closed this as completed in b537b64 Oct 30, 2021
pyropy added a commit that referenced this issue Oct 30, 2021
Fixed #24 invalid enter_room and leave_room
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant