Fix suspending with process groups #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since using raw mode via `raw.lflag &= ~(… | termios.ISIG)` pyrepl needs
to handle SIGSTOP itself, but before this patch would only signal its
own process.
Using `0` for the pid signals the process group instead.
Manual test:
When running the following from a shell `Ctrl-z` will not give you the
shell's prompt, but the process is stuck, and needs to be signaled to
continue using `kill -CONT $pid`:
> python -c 'import os; os.system("python pyrepl/reader.py")'
I have noticed this when using pdbpp with pytest, which was wrapped in a
shell script, not using `exec python …`.
blueyed
added a commit
to blueyed/pyrepl
that referenced
this pull request
May 19, 2022
I have not seen this to be necessary, but it goes in line with handling SIGSTOP then (pypy#49).
|
cool, I also have noticed this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since using raw mode via
raw.lflag &= ~(… | termios.ISIG)pyrepl needsto handle SIGSTOP itself, but before this patch would only signal its
own process.
Using
0for the pid signals the process group instead.Manual test:
When running the following from a shell
Ctrl-zwill not give you theshell's prompt, but the process is stuck, and needs to be signaled to
continue using
kill -CONT $pid:I have noticed this when using pdbpp with pytest, which was wrapped in a
shell script, not using
exec python ….