Skip to content

Hotfix for Directory not empty errors #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 15, 2025

  • Only attempt to fetch eggs for unsatisfied requirements.
  • In installer, when discovering egg dists, let metadata discovery search each egg.

Summary of changes

Closes #4998

Pull Request Checklist

@jaraco
Copy link
Member Author

jaraco commented May 15, 2025

I'm not planning to write tests for this code, as it's long deprecated and slated for removal, so as long as we can get it to work for a few cases (such as those illustrated in #4998), it should be a good enough bandaid to make it through the year (but also to remove reliance on pkg_resources).

@jaraco jaraco merged commit 31f8cac into main May 15, 2025
34 of 38 checks passed
@jaraco jaraco deleted the bugfix/4998-directory-not-empty branch May 15, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in installer - Directory not empty
1 participant