Skip to content

Remove PyMC adapter #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Remove PyMC adapter #89

merged 1 commit into from
Mar 30, 2023

Conversation

michaelosthege
Copy link
Member

It's now supported by PyMC directly, since v5.1.1.

Closes #11 because adapters should no longer be located here.

It's now supported by PyMC directly, since v5.1.1.

Closes #11 because adapters should no longer be located here.
@michaelosthege
Copy link
Member Author

Want to review, @qacwnfq / @ANTS-ON?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.28 ⚠️

Comparison is base (114f38d) 96.07% compared to head (c803151) 95.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   96.07%   95.80%   -0.28%     
==========================================
  Files           9        8       -1     
  Lines         637      500     -137     
==========================================
- Hits          612      479     -133     
+ Misses         25       21       -4     
Impacted Files Coverage Δ
mcbackend/__init__.py 77.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ANTS-ON ANTS-ON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me.

@michaelosthege michaelosthege merged commit 5dca137 into main Mar 30, 2023
@michaelosthege michaelosthege deleted the remove-adapters branch March 30, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an emcee adapter
3 participants