Skip to content

Give more informative errors for unsupported dtypes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

michaelosthege
Copy link
Member

Helps to diagnose which variables or stats cause problems when initializing a ClickHouseRun.

@michaelosthege michaelosthege added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 2, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 96.58% // Head: 96.59% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (36f76c6) compared to base (8e845aa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   96.58%   96.59%   +0.01%     
==========================================
  Files           7        7              
  Lines         585      587       +2     
==========================================
+ Hits          565      567       +2     
  Misses         20       20              
Impacted Files Coverage Δ
mcbackend/backends/clickhouse.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michaelosthege michaelosthege marked this pull request as ready for review December 2, 2022 15:08
@michaelosthege michaelosthege merged commit d504c77 into main Dec 2, 2022
@michaelosthege michaelosthege deleted the better-keyerrors branch December 2, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants