Skip to content

Fix encoding/decoding of F-ordered NumPy arrays #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

michaelosthege
Copy link
Member

The relevant details can be found in a code comment.

Closes #63

@michaelosthege michaelosthege added bug Something isn't working important Work on this first labels Oct 9, 2022
@michaelosthege michaelosthege self-assigned this Oct 9, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 95.97% // Head: 96.58% // Increases project coverage by +0.60% 🎉

Coverage data is based on head (a78b7b8) compared to base (9528939).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   95.97%   96.58%   +0.60%     
==========================================
  Files           8        7       -1     
  Lines         596      585      -11     
==========================================
- Hits          572      565       -7     
+ Misses         24       20       -4     
Impacted Files Coverage Δ
mcbackend/npproto/__init__.py 100.00% <100.00%> (ø)
mcbackend/npproto/utils.py 100.00% <100.00%> (ø)
mcbackend/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michaelosthege michaelosthege merged commit 7a22e59 into main Oct 9, 2022
@michaelosthege michaelosthege deleted the issue-63 branch October 9, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important Work on this first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf encode/decode of NumPy arrays fails if they were F-ordered
2 participants