Coerce Series to dict in Dataset constructor #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Need to coerce Series to a dict as it doesn't implement __iter__ like a mapping | ||
| # GH470 | ||
| vars = dict(vars) if isinstance(vars, pd.Series) else vars |
There was a problem hiding this comment.
Can we do the two-liner instead? It's an extra line but less text -- and is clearer IMO
shoyer
added a commit
that referenced
this pull request
Feb 17, 2016
Coerce Series to dict in Dataset constructor
|
Would have been happy to do the two line version - agree it's clearer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #740