Handle non-numpy dtypes without erroring #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
shoyer
force-pushed
the
index-dtype-fixes
branch
from
75665c9 to
03eb185
Compare
Fixes GH716
shoyer
force-pushed
the
index-dtype-fixes
branch
from
03eb185 to
58b42af
Compare
|
The test failure is unrelated and fixed by #702 |
shoyer
added a commit
that referenced
this pull request
Jan 13, 2016
Handle non-numpy dtypes without erroring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course, we still need to coerce them to a numpy dtype for use in xray (e.g., object)
Fixes #716