BUG: ensure xray works with pandas 0.17.0 #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using some internal routines in pandas to convert object of datetime objects arrays to datetime64. Predictably, these internal routines have now changed, breaking xray. This is definitely my fault but also bad luck -- I had a guard against the internal function dissappearing, but not against the keyword arguments changing. In any case, this fix ensures forwards compatibility with the next release of pandas, which will be coming out next week.
|
Given that we are so dependent on pandas, might it be a good idea to add a travis build/test using pandas' master branch? |
|
@jhamman great idea, just set that up. Inadvertently, we were already sort of doing this -- looks like the build that install bottleneck from the pandas anaconda channel is also pulling in dev builds of pandas sometimes. |
|
nice. this looks good. |
shoyer
added a commit
that referenced
this pull request
Sep 11, 2015
BUG: ensure xray works with pandas 0.17.0
This was referenced Sep 11, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using some internal routines in pandas to convert object of datetime
objects arrays to datetime64. Predictably, these internal routines have now
changed, breaking xray.
This is definitely my fault but also bad luck -- I had a guard against the
internal function dissappearing, but not against the keyword arguments
changing.
In any case, this fix ensures forwards compatibility with the next release of
pandas, which will be coming out next week.