Fix swap_dims() index names (issue #3748) #3752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a simple test, but not sure it is correctly set up. I wasn't sure about how pytest fixtures worked, so I didn't know if I needed/how to set up a new fixture to test the bugfix. |
|
The 4 pytest failures per check are taking place in |
+ integrated new tests for GH3748 for DataArray into existing swap_dims tests + added similar tests for Dataset + added test for multiindex case
jaicher
force-pushed
the
fix-gh-issue-3748
branch
from
a1dfd46 to
f5b66f3
Compare
|
We have different test failures than last time. They appear to be happening in tests with time indexes this time. I suspect these failures are again unrelated to the pull request. |
|
test failure is unrelated. Thanks @jaicher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swap_dims()incorrectly changes underlying index name #3748isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API