Skip to content

avoid integer overflow when decoding large time numbers #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

avoid integer overflow when decoding large time numbers #2096

wants to merge 4 commits into from

Conversation

j08lue
Copy link
Contributor

@j08lue j08lue commented May 1, 2018

@j08lue j08lue mentioned this pull request May 1, 2018
Closed
3 tasks
@j08lue
Copy link
Contributor Author

j08lue commented May 1, 2018

That single AppVeyor CI fail is because the py27 32bit conda environment cannot be created:

ResolvePackageNotFound: 
  - cftime

@fmaussion
Copy link
Member

I'm confused. It seems that I did exactly this a while ago: #2015

Anyways, it seems that your issue #1965 is a duplicate of #2002 and was corrected by my PR. Or am I missing something here?

@j08lue
Copy link
Contributor Author

j08lue commented May 1, 2018

I'm confused. It seems that I did exactly this a while ago

@fmaussion don't be. You are perfectly right, we worked on the same line of code, only that I was about 50 PRs earlier, hence the merge conflict.

I'll close this.

@j08lue j08lue closed this May 1, 2018
@j08lue j08lue deleted the time-large-int branch May 1, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j08lue @fmaussion