Skip to content

Add netcdftime as an optional dependency. #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2018
Merged

Add netcdftime as an optional dependency. #1920

merged 8 commits into from
Feb 19, 2018

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Feb 16, 2018

  • Helps with Towards a (temporary?) workaround for datetime issues at the xarray-level #1084
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

I've added a temporary travis build with the master branch of netcdftime. After a while, we can probably remove that.

This is helping us move towards Unidata/netcdf4-python#601 and #1252

cc @jswhit and @spencerkclark

@jhamman
Copy link
Member Author

jhamman commented Feb 18, 2018

@spencerkclark, mind giving this a review?

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhamman this looks good to me, thanks!

@jhamman jhamman merged commit e544e0d into pydata:master Feb 19, 2018
@jhamman jhamman deleted the feature/netcdftime branch February 22, 2018 03:23
@spencerkclark spencerkclark mentioned this pull request Apr 13, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants