Fix resample/interpolate for non-upsampling case #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
changed the title
|
Great catch; do you need any input from me @jhamman ? |
shoyer
approved these changes
Oct 5, 2017
max-sixty
reviewed
Oct 5, 2017
xarray/tests/test_dataarray.py
Outdated
| dims=('time', 'x', 'y'), | ||
| coords={'time': dates}) | ||
| actual = expected.resample(time='1D').interpolate('linear') | ||
| self.assertDataArrayAllClose(actual, expected, rtol=1e-16) |
There was a problem hiding this comment.
@jhamman reminder to use the assert functions rather than self. ... methods, for future PRs
|
yes, this was a nice and easy fix. In the future, it may be nice to fast track no-op resample/interpolation since this does end up doing the same computation as it would if there were actual missing values but, this is a nice improvement for now. Thanks again @darothen for the upsampling and resample refactor. |
|
I'm a bit slow on the uptake here, but big 👍 from me. Thanks for catching this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff[ ] Fully documented, includingwhats-new.rstfor all changes andapi.rstfor new APIcc @darothen