Consolidate common code in PYBIND11_MODULE and PYBIND11_EMBEDDED_MODULE #5670
+73
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to one macro The difference between the two is really small, almost all of the code was the same.
|
|
|
The the AppVeyor failure looks like a temporary infrastructure failure, but this one seems real, almost certainly a consequence of #5523: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As requested in #5665 by @rwgk.
The difference between the two macros is really small, almost all of the code is the same. So we can consolidate it into a common macro called by both. Both macros still exist and take the same number of arguments.