minor documentation updates #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikofski
reviewed
May 17, 2017
| @@ -38,26 +38,33 @@ def get_solarposition(time, latitude, longitude, | |||
| Parameters | |||
| ---------- | |||
| time : pandas.DatetimeIndex | |||
|
|
|||
There was a problem hiding this comment.
@wholmgren did you really mean to add all of these extra newlines? Should I merge them, or was it a typo? I can't find the rationale in your comments, and it's inconsistent with docstrings everywhere else. Please let me know. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of minor updates to the documentation. Closes #297 (communication forums).
Partially addresses #302 (LT/AOD examples). Adds some notes about recommended solar position methods (relevant to #301). Updates the doc environment to use newer packages.
It's rendered here:
http://wholmgren-pvlib-python-new.readthedocs.io/en/docupdates/index.html
Let know if you have any suggestions.