Skip to content

Include SolarAnywhere API key in pytest-remote-data.yml #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

AdamRJensen
Copy link
Member

This PR includes the SolarAnywhere API key in the pytest-remote-data.yml file. The API key is used for testing in #1497, however, it needs to be available to the main branch prior to merging of #1497 as the API key is required for the remote tests to work.

I think it is just the annoying but secure behavior of pull-request-target not respecting yml changes in the PR -- your update to include the SA key in the environment isn't taking effect because the action is defined by the .github/workflows/pytest-remote-data.yml file on master, not this PR branch. I guess the cleanest workaround is to submit a separate PR to change pytest-remote-data.yml, merge that, then merge master into this PR?

Originally posted by @kanderso-nrel in #1497 (comment)

@AdamRJensen AdamRJensen added the io label Aug 17, 2022
@kandersolar kandersolar added this to the 0.9.2 milestone Aug 17, 2022
@kandersolar kandersolar merged commit 9144a3b into pvlib:master Aug 17, 2022
@AdamRJensen AdamRJensen deleted the solaranywhere_credentials branch June 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants