-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve get_cams documentation #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AdamRJensen please look into this pr |
@soma2000-lang I noticed that the stickler-ci check is failing, which means that there is some formatting check that is not passing, e.g., a line that is too longer than 79 characters. You can click the "Details" button to the right of the stickler-ci to see the error. |
It happens sometimes that you fix a stickler error, only to break another rule. Btw, I thought it was nice when you spelled out approximately in full. |
@AdamRJensen yes the error was showing that remove the trailing whitesapces ,I tried to solve that using these steps but its still showing the same error .Can you please help me in this regard |
@soma2000-lang The trailing white space refers to one or more spaces at the end of a line. The stickler-ci will show the warning just below the affected line, so that should help you find it another time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it looks good :)
pvlib/iotools/sodapro.py
Outdated
@@ -363,7 +360,7 @@ def read_cams(filename, integrated=False, label=None, map_variables=True): | |||
|
|||
See Also | |||
-------- | |||
pvlib.iotools.parse_cams, pvlib.iotools.get_cams | |||
pvlib.iotools.parse_cams,pvlib.iotools.get_cams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can go ahead and put this space back since this was not the trailing white space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @soma2000-lang
pvlib/iotools/sodapro.py
Outdated
latitude and longitude for CAMS Radiation | ||
|
||
|
||
Geographical coverage:worldwide for CAMS McClear and approximately -66° to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geographical coverage:worldwide for CAMS McClear and approximately -66° to | |
Geographical coverage: worldwide for CAMS McClear and approximately -66° to |
@AdamRJensen @cwhanse made the suugested changes |
@soma2000-lang There still is two stickler-ci lines being flagged. Notice that the stickler-ci tells you which line the errors are on, in this case "Check failure on line 61 and the error is blank line contains white space. Almost there :) |
@soma2000-lang please add yourself to the Contributors section of docs/source/sphinx/whatsnew/v0.9.1.rst |
Co-authored-by: Adam R. Jensen <[email protected]>
get_cams
documentation #1412docs/sphinx/source/reference
for API changes.