handle nan in tools.golden_sect_DataFrame #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
Feb 17, 2022
pvlib/tools.py
Outdated
|
|
||
| return func(df, 'V1'), df['V1'] | ||
| func_result = func(df, 'V1') |
There was a problem hiding this comment.
This PR gets #1394 working again for me locally, so +1 for that. However I think this will still fail with a KeyError if either of upper or lower is all nans: in that case iterlimit will still be nan, so the while loop will not execute at all, causing df['V1'] to not exist when this line executes. I think the all-nan case is worth supporting: a ModelChain simulation of only nighttime is not particularly useful, but shouldn't throw an error IMHO.
kandersolar
approved these changes
Feb 17, 2022
|
I guess my preference long term would be to replace this with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Supplements #1089. See discussion.