Skip to content

[bug] use clip instead of abs #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

mikofski
Copy link
Member

@mikofski mikofski commented Aug 8, 2021

  • Closes Incorrect AOI from pvlib.tracking.singleaxis #1221
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@mikofski mikofski added the bug label Aug 8, 2021
@mikofski mikofski added this to the 0.9.0 milestone Aug 8, 2021
@mikofski mikofski self-assigned this Aug 8, 2021
* check if single axis tracker has correct aoi when sun is behind modules by comparison to fixed and limiting rotation
@mikofski mikofski closed this Aug 8, 2021
@mikofski mikofski deleted the gh1221-fix-singleaxis-aoi branch August 8, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect AOI from pvlib.tracking.singleaxis
1 participant