Skip to content

Raise ValueError if PVSystem constructed with 0 Arrays #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2021

Conversation

wfvining
Copy link
Contributor

@wfvining wfvining commented May 10, 2021

Provides a useful error message directing users to the solution
they are most likely to want (construct a PVSystem with an
arbitrary default Array).

Provides a useful error message directing users to the solution
they are most likely to want (construct a PVSystem with an
arbitrary default Array).
@cwhanse cwhanse added this to the 0.9.0 milestone May 11, 2021
@wfvining wfvining requested a review from cwhanse May 17, 2021 13:30
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwhanse cwhanse mentioned this pull request May 17, 2021
24 tasks
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wfvining

@wholmgren wholmgren merged commit 0326b6f into pvlib:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should be impossible to instantiate a PVSystem with no Arrays
3 participants