Skip to content

Right-associative :|, proper tests and PureScript 0.8 updates #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2016

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 31, 2016

This PR includes a few things:

  • Updates for PureScript 0.8 (fix warnings and use new operator alias syntax)
  • Make :| right-associative
  • Add test suite (previously, Test.Main just printed a few things to the console)

If you would prefer a PureScript 0.7 - compatible PR, let me know.

Remark: it's slightly unfortunate that we have to (?) define a synonym nonEmpty = NonEmpty in order to define the operator :|. It would be nice if we could use:

infixr 6 NonEmpty as :|

Make the operator `:|` right-associative in order to
enable code like this:
``` purescript
0 :| 1 :| [2, 3]
```

Uses PureScript 0.8 syntax and fixes a couple of warnings.
Previously, the Test.Main module only printed some values to the
console. This commit adds a few simple tests using Test.Assert.
paf31 added a commit that referenced this pull request Jan 31, 2016
Right-associative :|, proper tests and PureScript 0.8 updates
@paf31 paf31 merged commit 1897c64 into purescript:master Jan 31, 2016
@paf31
Copy link
Contributor

paf31 commented Jan 31, 2016

Thanks very much!

@sharkdp sharkdp mentioned this pull request Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants