Skip to content

fix: Fix Foldable1 (Coyoneda f) instance #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Fix Foldable1 (Coyoneda f) instance #105

wants to merge 1 commit into from

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Oct 24, 2020

JordanMartinez
JordanMartinez approved these changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether it would be more efficient to handwrite the implementation for foldr1/foldl1. I'll let other maintainers comment.

@srghma
Copy link
Contributor Author

srghma commented Oct 24, 2020

I actually tried to rewrite it with foldXXX1 of f, but didnt manage to solve

@JordanMartinez
Copy link
Contributor

Included in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srghma @JordanMartinez