Export specialized any and all from Data.Array and Data.Array.NonEmpty #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
approved these changes
Dec 19, 2020
hdgarrood
reviewed
Dec 19, 2020
src/Data/Array.purs
Outdated
| @@ -1192,6 +1195,12 @@ unzip xs = | |||
| snds' <- STA.unsafeFreeze snds | |||
| pure $ Tuple fsts' snds' | |||
|
|
|||
| -- | Returns true if at least one array element satisfy the given predicate. | |||
There was a problem hiding this comment.
We want “satisfies” here rather than “satisfy” for subject-verb agreement. Also, I think it would be nice to explain why we have specialised HeytingAlgebra to Boolean?
There was a problem hiding this comment.
A couple of simple examples would also be nice, I guess
There was a problem hiding this comment.
I updated the documentation, added some examples I fancied more than the tests and updated the tests.
57 tasks
thomashoneyman
approved these changes
Dec 19, 2020
kl0tl
force-pushed
the
specialized-any-and-all
branch
from
25085ad to
7bcd572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #189, this pull request specialize two more functions. Exporting
any, all :: forall a. (a -> Boolean) -> Array a -> Booleaninstead ofany, all :: forall a b f. Foldable f => HeytingAlgebra b => (a -> b) -> f a -> ballows to stop iterating the array as soon as the predicate yields true for any or false for all.