This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Hide Sidebar on Simple Window (Popup) #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is generally a good practice to provide users with options to customize their experience and enable or disable certain features as they see fit. However, in the case of the sidebar in question, it may not be appropriate to offer an option to enable or disable it due to the potential impact on the functionality and responsiveness of the feature in which it may lead to a poor user experience. What is your thoughts @trickypr |
|
I am fine not including a toggle for this |
trickypr
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Works when tested on this test case: https://jsfiddle.net/8g12v73n/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, the use case for displaying a sidebar in a small window, such as a login authentication window or debugging tool, is rare. These types of windows are typically designed to perform a specific task and do not require the additional screen real estate or functionality that a sidebar would provide. Additionally, the limited size of these windows may make it difficult to effectively utilize a sidebar without compromising the usability of the primary content.
For these reasons, it may be more appropriate to omit the sidebar in small windows that utilize the Window API or do not have an omnibox. This allows for a streamlined user experience that is focused on the primary task at hand, rather than being cluttered with unnecessary features.