Skip to content

wasmtime: update to v2.0.2. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Conversation

phlax
Copy link
Contributor

@phlax phlax commented Nov 21, 2022

Signed-off-by: Ryan Northey [email protected]

@phlax phlax marked this pull request as draft November 21, 2022 16:59
@PiotrSikora PiotrSikora requested a review from mpwarres November 21, 2022 17:17
@PiotrSikora
Copy link
Member

You need to regenerate Bazel rules (see discussion in #309).

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

im hitting this

$ cargo-raze --generate-lockfile
Error: Failed to load lockfile: /tmp/.tmp7bTIAD/Cargo.lock

Caused by:
    I/O operation failed: couldn't open /tmp/.tmp7bTIAD/Cargo.lock: No such file or directory (os error 2)

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

ive cleaned my cache and tried again - same result

if i try to run cargo update (iiuc this creates the missing file) - i get

$ cargo update
    Updating crates.io index
    Updating git repository `https://github.com/bytecodealliance/wasmtime`
error: failed to select a version for the requirement `wasmtime = "^2.0.2"`
candidate versions found which didn't match: 0.37.0, 0.36.0, 0.35.3, ...
location searched: crates.io index
required by package `wasmtime-c-api-bazel v2.0.2 (/home/phlax/dev/envoydev/proxy-wasm-cpp-host/bazel/cargo/wasmtime)`

which is wierd because wasmtime defo has 2.0.2 on crates.io

@PiotrSikora
Copy link
Member

The error is not very helpful, but I believe that updating Rust to a more recent version (rustup update) should fix it.

@phlax phlax force-pushed the deps-bump-wasmtime2 branch 2 times, most recently from 70c0099 to 2f0eee3 Compare November 21, 2022 18:10
@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

afaict this will need rules_rust to be updated - i think its being updated in the cargo generated files - but the repo has not been updated

@PiotrSikora
Copy link
Member

Which version of cargo-raze are you using? The diff looks a quite large for such a small update.

Also, could you split the licenses fix into separate PR? I'll merge it right away.

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

$ cargo install cargo-raze --version 0.12.0

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

#320

@PiotrSikora
Copy link
Member

You need cargo install cargo-raze --version 0.14.1.

@phlax phlax force-pushed the deps-bump-wasmtime2 branch 2 times, most recently from c8aed9e to da519ad Compare November 21, 2022 20:23
@phlax phlax marked this pull request as ready for review November 21, 2022 21:17
@PiotrSikora
Copy link
Member

You need to remove the duplicate select statements from Bazel rules for errno and rustix crates (see: f8f1c07).

@phlax
Copy link
Contributor Author

phlax commented Nov 21, 2022

im not 100% that i changed the right things

@phlax phlax force-pushed the deps-bump-wasmtime2 branch 2 times, most recently from 8e5b830 to 4950721 Compare November 22, 2022 13:31
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the deps-bump-wasmtime2 branch from 8e66f9e to 9ba24ba Compare November 22, 2022 14:39
@phlax
Copy link
Contributor Author

phlax commented Nov 22, 2022

WIP Envoy PR is here envoyproxy/envoy#24150

@phlax phlax force-pushed the deps-bump-wasmtime2 branch from de488d3 to 9ba24ba Compare November 22, 2022 15:45
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@PiotrSikora PiotrSikora changed the title deps: Bump com_github_bytecodealliance_wasmtime -> 2.0.2 wasmtime: update to v2.0.2. Nov 22, 2022
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit 624ef2e into proxy-wasm:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants