WAMR support clone

[lum1n0us]

• Let WAMR support CompiledBytecode level of clone
• enable WAMR JIT
• upgrade to a WMAR newer commit

[PiotrSikora]

@mpwarres PTAL

[lum1n0us]

@PiotrSikora @mathetake Just a reminder, please take a look. I am looking forward to your comments.

BTW, is there any update about the feature of supporting AOT files as a kind of pre-compiled .Wasm files?

[PiotrSikora]

@PiotrSikora @mathetake Just a reminder, please take a look. I am looking forward to your comments.

@mpwarres took over this codebase, so I'll let him review this PR.

BTW, is there any update about the feature of supporting AOT files as a kind of pre-compiled .Wasm files?

Precompiled modules have been supported since day one. They are implemented for V8 and WAVM engines, but you need to add support for WAMR if you want, which should be pretty easy. Note that both of them currently load precompiled code from a Custom Section of .wasm module, so you'd need to wire this up yourself if you want to load precompiled modules from a separate files, but I don't see a reason why it shouldn't be supported.

[mpwarres]

Yup, looking at it today.

[lum1n0us]

bytecodealliance/wasm-micro-runtime#1291 ... ... adding option in Proxy-Wasm C++ Host and Envoy to simply consume precompiled Wasm module from a separate file instead, we need to do that for Wasmtime anyway.

so you'd need to wire this up yourself if you want to load precompiled modules from a separate files, but I don't see a reason why it shouldn't be supported.

@PiotrSikora Thanks for answering. Just to be sure we are on the same page that

• Proxy Wasm C++ Host would like to have a feature that Wasm Runtimes simply consume precompiled Wasm module from a separate file
• And there is no ongoing development on this feature as we know for now

[PiotrSikora]

@lum1n0us correct.

[lum1n0us]

@PiotrSikora Great! Then I think we might working on it and provide a patch to enable the feature.

[PiotrSikora]

LGTM, but could you also send a draft PR to Envoy updating WAMR and Proxy-Wasm C++ Host to your branch, so that it'd pass the tests there?

[lum1n0us]

Here it is envoyproxy/envoy#24200.

[PiotrSikora]

Here it is envoyproxy/envoy#24200.

It looks that it fails when running WAMR tests, e.g.:

[2022-11-25 06:34:36.458][20][error][wasm] [external/envoy/source/extensions/common/wasm/wasm_vm.cc:38] Function: proxy_on_context_create failed: Exception: thread signal env not inited
[2022-11-25 06:34:36.458][20][error][wasm] [external/envoy/source/extensions/common/wasm/wasm_vm.cc:38] Function: proxy_on_vm_start failed: Exception: thread signal env not inited
[2022-11-25 06:34:36.458][20][error][wasm] [external/envoy/source/extensions/common/wasm/wasm.cc:109] Wasm VM failed Failed to start thread-local Wasm

Could you take a look?

[lum1n0us]

All fixed. envoyproxy/envoy#24200 😮‍💨

[mpwarres]

A couple minor questions, just for my own understanding.

@PiotrSikora already looked at and signed off on these changes. I'll wait a day in case he wants to take a final look, but can otherwise merge them if he's done.

[lum1n0us]

@mathetake I know you are very busy, so I appreciate you can review the PR. Thanks very much.