Review of WasmVM. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
mattklein123
suggested changes
Mar 9, 2020
Comment on lines
+1
to
+2
| // Copyright 2016-2019 Envoy Project Authors | ||
| // Copyright 2020 Google LLC |
There was a problem hiding this comment.
? Related to comment above.
mattklein123
approved these changes
Mar 9, 2020
lum1n0us
pushed a commit
to lum1n0us/proxy-wasm-cpp-host
that referenced
this pull request
Apr 11, 2021
Compile WAMR from Source Code
jlb6740
pushed a commit
to jlb6740/proxy-wasm-cpp-host
that referenced
this pull request
Jul 16, 2022
update wasmtime to 0.29.0
martijneken
added a commit
to martijneken/proxy-wasm-cpp-host
that referenced
this pull request
Aug 1, 2024
This moves ProxyWasm past Envoy Abseil 20230802.1.
Relevant ASAN failure:
```
external/com_google_absl/absl/strings/numbers.cc:199:73: runtime error: unsigned integer overflow: 0 - 8 cannot be represented in type 'unsigned long long'
#0 0x562c730539f9 in absl::lts_20230802::(anonymous namespace)::EncodeTenThousand(unsigned int, char*) numbers.cc
proxy-wasm#1 0x562c73053f25 in absl::lts_20230802::numbers_internal::FastIntToBuffer(unsigned long, char*)
```
Relevant Abseil rollback: abseil/abseil-cpp@e7858c7
Signed-off-by: Martijn Stevenson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.