Skip to content

Update Dagger and build. #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Update Dagger and build. #1610

merged 2 commits into from
Sep 2, 2024

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 31, 2024

  • Update dagger actions to use pinnning.
  • Add /dagger to dependabot to keep the Dagger modules up-to-date.
  • Update dagger default Go version.
  • Update tutorials/whatsup Go version.
  • Update actions to use pinning.

@SuperQ SuperQ changed the title Add /dagger to dependabot Update Dagger and build. Sep 1, 2024
@SuperQ
Copy link
Member Author

SuperQ commented Sep 1, 2024

Another yak shaving for #1601

* Update dagger actions to use pinnning.
* Add /dagger to dependabot to keep the Dagger modules up-to-date.
* Update dagger default Go version.
* Update tutorials/whatsup Go version.
* Update actions to use pinning.

Signed-off-by: SuperQ <[email protected]>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question, but code LGTM

Thanks for working on this :)

@@ -17,15 +17,15 @@ permissions: # added using https://github.com/step-security/secure-repo
jobs:
golangci:
permissions:
contents: read # for actions/checkout to fetch code
contents: read # for actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? This is a comment, so I'm not sure if dependabot will keep this up-to-date as well 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a sed skill issue on my part. 😹

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit reverting it then :)

@ArthurSens ArthurSens enabled auto-merge (squash) September 2, 2024 11:34
@ArthurSens ArthurSens merged commit 2cc3a2f into main Sep 2, 2024
10 checks passed
@ArthurSens ArthurSens deleted the superq/dagger branch September 2, 2024 11:40
amberpixels pushed a commit to amberpixels/prometheus_client_golang that referenced this pull request Nov 29, 2024
* Update Dagger and build

* Update dagger actions to use pinnning.
* Add /dagger to dependabot to keep the Dagger modules up-to-date.
* Update dagger default Go version.
* Update tutorials/whatsup Go version.
* Update actions to use pinning.

Signed-off-by: SuperQ <[email protected]>

---------

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Eugene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants