Add ordinal plural example to guide #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should bring back explicit |
|
I'd recommend keeping the current behaviour. Yes, it is admittedly a bit surprising, but it's not really misleading as such. It also conceptually matches the current special-casing of |
stasm
approved these changes
Apr 23, 2019
| ``` | ||
| your-rank = { NUMBER($pos, type: "ordinal") -> | ||
| [1] You finished first! | ||
| [one] You finished {$pos}st |
There was a problem hiding this comment.
Great use of an explicit [1] variant combined with the generic [one]!
Cimbali
added a commit
to Cimbali/python-fluent
that referenced
this pull request
Oct 18, 2023
The type option is simply ignored outside of a select expression, and allows to select based on CLDR plural categories for ordinals (which differ from normal plurals aka cardinal numbers). This is as per (part of) the docs, and per javascript implementation, see projectfluent/fluent#259 -- I haven’t found any definition of NUMBER() in the spec.
Cimbali
added a commit
to Cimbali/python-fluent
that referenced
this pull request
Oct 18, 2023
The type option is simply ignored outside of a select expression, and allows to select based on CLDR plural categories for ordinals (which differ from normal plurals aka cardinal numbers). This is as per (part of) the docs, and per javascript implementation, see projectfluent/fluent#259 -- I haven’t found any definition of NUMBER() in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's by no means obvious that
NUMBER()may also be used to implement selectors on ordinal rather than cardinal plural categories, this PR adds a note about this to the syntax guide.What's happening here is that the same options that are passed to
Intl.NumberFormatare also passed toIntl.PluralRules, and NumberFormat ignores thetypeoption. Admittedly there is a bit of a wtf stage that you go through if you start to think about this.I'm not sure how JS-specific this functionality is.