Skip to content

Run clippy on CI #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2024
Merged

Run clippy on CI #342

merged 2 commits into from
May 6, 2024

Conversation

pitbuster
Copy link
Contributor

@pitbuster pitbuster commented Feb 14, 2024

First take on #287. I am not sure if running nightly clippy is a requirement for the project (in my experience it is quite unstable), but we can work on that if that's the case.

Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be a new job or just part of the existing test workflow.

@alerque
Copy link
Collaborator

alerque commented Mar 9, 2024

Personally (having setup and managed a lot of CI stuff) I would probably not put this in the same workflow as the test and coverage jobs. I would either keep it completely separate like it is or adapt the existing format.yml workflow to include all linting related jobs. There isn't a huge difference between these options. Some tooling (like external badge services) make it a little easier to get the status of a workflow rather than a single job in a milti-job workflow, but it isn't a big deal.

@alerque alerque merged commit f6168c8 into projectfluent:main May 6, 2024
This was referenced May 6, 2024
@pitbuster pitbuster deleted the ci-clippy branch May 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants