-
Notifications
You must be signed in to change notification settings - Fork 54
Add notebook annotation to RayCluster #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook annotation to RayCluster #558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could improve the annotation to remove the path to the notebook?
For example my RC was given app.kubernetes.io/managed-by: /notebook/mark-dsp/mark-wb
Instead we should aim for app.kubernetes.io/managed-by: mark-wb
Is there any reason not to use the path here? The reason for the addition of this annotation is to allow the UI team to get the notebook URL for use on the frontend. |
@Fiona-Waters @Ygnas |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through this on my rosa cluster and it works as expected. Looks great to me, thanks Ignas!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2408b7a
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-6301
What changes have been made
Added the notebook prefix annotation to RayCluster when it was created from the workbench. That should allow to construct a workbench url for the metrics
Verification steps
Create a RayCluster from the Data Science Projects Workbench, the created cluster should have an annotation
app.kubernetes.io/managed-by:
Checks