Skip to content

Print Pytest output logs for easier test failure analysis #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jun 7, 2024

Issue link

What changes have been made

Currently the only way how to check Pytest log in PR check is to download PR check artifacts and open Pytest log file.
This PR will print Pytest log file into PR check console, o it can be easily seen there.

Verification steps

Check content of Pytest log file in PR check console.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2024
@sutaakar sutaakar marked this pull request as ready for review June 7, 2024 07:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2024
@sutaakar sutaakar requested a review from abhijeet-dhumal June 7, 2024 09:03
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@sutaakar sutaakar requested review from Fiona-Waters and removed request for franciscojavierarceo June 10, 2024 07:02
@Fiona-Waters
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit eb643ca into project-codeflare:main Jun 10, 2024
4 checks passed
@sutaakar sutaakar deleted the test-log branch June 10, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants