Skip to content

ci: split out build image and push from release into seperate WF #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

ci: split out build image and push from release into seperate WF #333

merged 1 commit into from
Aug 29, 2023

Conversation

dimakis
Copy link
Contributor

@dimakis dimakis commented Aug 29, 2023

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@dimakis dimakis requested a review from anishasthana August 29, 2023 14:51
@openshift-ci openshift-ci bot requested a review from KPostOffice August 29, 2023 14:51
@dimakis dimakis requested a review from sutaakar August 29, 2023 14:51
@dimakis dimakis force-pushed the update-release-workflow branch from 78e2f28 to a20866e Compare August 29, 2023 14:54
@dimakis dimakis force-pushed the update-release-workflow branch from a20866e to 42e7e21 Compare August 29, 2023 15:01
anishasthana
anishasthana approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sutaakar
sutaakar reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anishasthana
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anishasthana anishasthana merged commit c0db26e into main Aug 29, 2023
@anishasthana anishasthana deleted the update-release-workflow branch August 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar left review comments

@anishasthana anishasthana anishasthana approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@sutaakar sutaakar

@anishasthana anishasthana

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimakis @sutaakar @anishasthana