Github workflow for nightly builds #307
Conversation
| sed -i "s/codeflare-sdk==.*/${{ env.SDK_FILE }}\\\\/" custom-nb-image/Dockerfile | ||
| - name: Image Build | ||
| run: | | ||
| cd custom-nb-image |
There was a problem hiding this comment.
You can use working-directory instead - see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: |
There was a problem hiding this comment.
Can you rather use push event (i.e. https://github.com/project-codeflare/codeflare-operator/blob/main/.github/workflows/operator-image.yml#L6)?
That way the dev image is refreshed immediately.
jiripetrlik
force-pushed
the
291-nightly-image-builds
branch
3 times, most recently
from
e008aba to
967e122
Compare
|
@sutaakar Thank you for your comments. I tried to address all of them. @anishasthana @KPostOffice Hello, can you please take a look and merge if possible? |
| run: poetry build | ||
| - name: Copy SDK package | ||
| run: cp dist/${SDK_FILE} custom-nb-image | ||
| - name: Modify Dockerfile to use locally build SDK |
| sed -i "s/codeflare-sdk==.*/${{ env.SDK_FILE }}\\\\/" custom-nb-image/Dockerfile | ||
| - name: Image Build | ||
| working-directory: custom-nb-image | ||
| run: docker build -t quay.io/${{ env.QUAY_ORGANIZATION }}/notebook:${{ env.IMAGE_TAG }} . |
There was a problem hiding this comment.
nit: I'd prefer to use podman here instead of docker, but I won't block the PR on it.
jiripetrlik
force-pushed
the
291-nightly-image-builds
branch
from
967e122 to
f158fec
Compare
|
@Maxusmusti |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Maxusmusti, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Issue link
Closes #291
What changes have been made
New workflow was created. It will run each day and produce nightly image for notebook.
Verification steps
It was tested using my local fork: https://github.com/jiripetrlik/codeflare-sdk/actions/runs/5857794950/job/15880432547
Checks