Skip to content

[205] Fix codeflare-sdk release action #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

[205] Fix codeflare-sdk release action #220

merged 1 commit into from
Jul 21, 2023

Conversation

jiripetrlik
Copy link
Contributor

Fixes #205

Maxusmusti
Maxusmusti reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, when testing this myself, I am getting the following:

zsh: no matches found: *.html

Does this work locally for you, when you run pdoc --html -o docs src/codeflare_sdk && pushd docs && rm -rf cluster job utils && mv codeflare_sdk/* . && rm -rf codeflare_sdk && popd && find docs -type f -name *.html -exec bash -c "echo '' >> {}" \; in the codeflare-sdk dir? If so maybe it's just a mac issue...

@Maxusmusti
Copy link
Collaborator

Aha, wrapping the *.html in quotes ("*.html") solved the problems on my machine. So if that works for you as well, I'd recommend adding that.

@jiripetrlik
Copy link
Contributor Author

@Maxusmusti
Thank you for the review. It worked well on my Linux, but I've added quotes to be sure.

@Maxusmusti
Copy link
Collaborator

Awesome, looks like all it needs is a quick rebase and it's good for merging

@jiripetrlik
Copy link
Contributor Author

@Maxusmusti
Yes, thank you. It should be rebased now.

anishasthana
anishasthana approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anishasthana anishasthana merged commit d00eccb into project-codeflare:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxusmusti Maxusmusti Maxusmusti left review comments

@anishasthana anishasthana anishasthana approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix codeflare-sdk release action
3 participants
@jiripetrlik @Maxusmusti @anishasthana