Skip to content

update sdk and demos to ray 2.5 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

MichaelClifford
Copy link
Collaborator

I walked through each of the demos using a Ray 2.5 image and updating the driver environment to use Ray 2.5. Everything seemed to work without issue.

This PR updates all the requirements to point to Ray 2.5.0 instead of 2.1.0.

It also updates the default image in the cluster config to "rayproject/ray:2.5.0-py38-cu116"

I also used the image parameter in all of the cluster config calls just to make it more explicit that the image is configurable.

closes #134

@MichaelClifford MichaelClifford force-pushed the ray2.5 branch 3 times, most recently from 1c33580 to 88c5f4e Compare June 16, 2023 18:22
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't some of the examples need PyTorch installed now since it is no longer present by default in the image? Otherwise this LGTM at first glance.

@jbusche
Copy link
Contributor

jbusche commented Jul 6, 2023

Testing all the notebooks, and I'm noticing trouble with 2 of them:
3_basic_interactive.ipynb and hf_interactive.ipynb, at the assert ray_cluster_uri, step they're complaining about

AttributeError: 'JobConfig' object has no attribute '_py_driver_sys_path'

I want to try now with with the regular code and see if it's the same there, or maybe I'm doing something wrong... not sure.

@MichaelClifford
Copy link
Collaborator Author

@KPostOffice the notebook image still contains pytorch. It gets installed with the rest of our requirements.

@MichaelClifford
Copy link
Collaborator Author

@jbusche are you using ray 2.5 in your working environment? I had the same issue if I did not use the right version of Ray

@tedhtchang
Copy link
Member

tedhtchang commented Jul 6, 2023

This PR also fixes #170

@jbusche
Copy link
Contributor

jbusche commented Jul 6, 2023

LGTM Michael showed me how to update the Ray version in the notebook:

  • Open a terminal
  • Issue the following pip commands:
pip list |grep ray
ray                      2.1.0
....
pip install -U ray==2.5.0
....
pip list |grep ray
ray                      2.5.0

And then restart any running notebooks

All the notebooks worked well after that. Thanks Michael!

Copy link
Contributor

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to substitute an image in a few locations

@jbusche
Copy link
Contributor

jbusche commented Jul 7, 2023

Looks good Michael, Images pulling fine:

oc get appwrapper
NAME        AGE
mnisttest   3m46s
[[email protected] ~]# oc describe pods |grep Image:
    Image:         quay.io/project-codeflare/ray:2.5.0-py38-cu116
    Image:         busybox:1.28
    Image:         quay.io/project-codeflare/ray:2.5.0-py38-cu116
    Image:         quay.io/project-codeflare/ray:2.5.0-py38-cu116
    Image:         busybox:1.28
    Image:         quay.io/project-codeflare/ray:2.5.0-py38-cu116
    Image:         quay.io/project-codeflare/ray:2.5.0-py38-cu116

@anishasthana anishasthana merged commit baec858 into project-codeflare:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK Notebook image + demos to use recent version of Ray.
5 participants