Skip to content

Update testing instruction #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tedhtchang
Copy link
Member

Improve testing instruction for contributors to run the unit tests.

Co-authored-by: Anish Asthana <[email protected]>
@tedhtchang tedhtchang requested a review from anishasthana June 1, 2023 01:15
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anishasthana anishasthana dismissed their stale review June 7, 2023 19:16

dismiss

@tedhtchang
Copy link
Member Author

Thanks @MichaelClifford. I verified again they don't need a real cluster.

@MichaelClifford
Copy link
Collaborator

LGTM @tedhtchang thanks for the changes :)

@MichaelClifford MichaelClifford merged commit 3b41a22 into project-codeflare:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants