Skip to content

Create a Ray Cluster SDK upgrade scenarios during OLM upgrade #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Dec 12, 2023

Issue link

#184

What changes have been made

  • Added Ray Cluster SDK upgrade scenarios tests TestMNISTRayClusterUp and TestMnistJobSubmit in upgrade package to run the test before an operator upgrade and after upgrade
  • Adjusted the workflows olm_tests.yaml to include Raycluster upgrade scenarios tests

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Srihari1192 Srihari1192 force-pushed the upgrade-test-184 branch 3 times, most recently from fc4f46d to a6c9894 Compare December 13, 2023 06:51
@Srihari1192 Srihari1192 force-pushed the upgrade-test-184 branch 5 times, most recently from 7b50b19 to c71c3a5 Compare January 9, 2024 09:12
@Srihari1192 Srihari1192 marked this pull request as ready for review January 11, 2024 06:44
@openshift-ci openshift-ci bot requested review from dimakis and Maxusmusti January 11, 2024 06:44
@astefanutti
Copy link
Contributor

/lgtm

@sutaakar
Copy link
Contributor

@Srihari1192 Could you move this code into SDK repo? So that all SDK related tests are on one place.

@Srihari1192
Copy link
Contributor Author

@Srihari1192 Could you move this code into SDK repo? So that all SDK related tests are on one place.

Sure will move this to sdk repo

@Srihari1192
Copy link
Contributor Author

Closing this PR as moving these tests into codeflare-sdk project-codeflare/codeflare-sdk#440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants