Axis names fix #601
Axis names fix #601
Conversation
|
@VeraZab can you review this as well please, given that you spent so much time working on this initially? :) |
| const multipleSublots = | ||
| fullLayout && | ||
| fullLayout._subplots && | ||
| Object.values(fullLayout._subplots).some(s => s.length > 1); |
There was a problem hiding this comment.
hmm, fullLayout._subplots is an object right
that contains subplotTypes as keys, and arrays as values, and we want to check that those arrays are of length greater than 1.
so isn't it more like:
Object.values(fullLayout._subplots).some(s => fullLayout[s].length > 1);
There was a problem hiding this comment.
Vera, it's Object.values(), not Object.keys()
There was a problem hiding this comment.
okkk, yup, i see that now haha
|
other than the above, looks good to me! |
|
💃 |
|
can you force-push here to re-trigger circle and percy plz? |
|
CircleCI is still down as of 6 minutes ago |
|
I'm thinking Overlay should have an explicit option for "none" - it took me a while to figure out that I have to clear it to spread out the plots. |
|
Agreed, please add 'none'. This will close #479 |
|
err, am I still passing review after all these commits? :) |
|
@VeraZab please re-review if needed! I think the behaviour is fine for me. The only known-weird thing left outstanding with the secondary y-axis thing is plotly/plotly.js#2828 |
|
ok rechecked looks good 💃 |
addresses #575
closes #479