Skip to content

Choldgraf custom colors trisurf #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2016
Merged

Conversation

Kully
Copy link
Contributor

@Kully Kully commented May 27, 2016

@choldgraf @theengineear

Added the 'it' to that error message. Everything worked on my end and it looks good.

Plus, I made some modern art with import random:

modern art

@Kully Kully mentioned this pull request May 27, 2016
@theengineear
Copy link
Contributor

Great! 💃

@choldgraf
Copy link
Contributor

hah that's awesome. (so I shouldn't worry about my PR anymore, right?)

@theengineear
Copy link
Contributor

Yah @choldgraf to speed things up, we're just knabbing your commits and throwing them into a plotly/plotly.py repo branch to iterate a bit more collaboratively here as necessary.

Note that you can still add updates to your branch as necessary and we can either rebase or merge them into the new branch we've created to include them.

We're just avoiding having weird code state in our master branch as much as possible.

@choldgraf
Copy link
Contributor

no problem, if you guys are happy w/ this codebase then I say go for it. I'll push a little repo to do brain plotting, and we can see how the performance holds up. I got it down to ~4-6 seconds on the python side on my browser, and probably another 4-5 seconds for the browser to actually render the scene and plot. The biggest challenge I came across was that it looks like something isn't getting garbage collected on the JS side, because after a few plots the browser becomes really slow and uses up a ton of memory. But that's probably for a different PR.

@Kully Kully merged commit bef62ef into master May 27, 2016
@Kully Kully deleted the choldgraf-custom_colors_trisurf branch May 27, 2016 17:14
@cldougl
Copy link
Member

cldougl commented May 27, 2016

@Kully (cc @choldgraf ) I'm updating our pip version now, could you update the changelog when you have a minute (your changes will be applied to v1.11.0) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants