-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add sync option to tickmode
of cartesian axes to sync ticks with overlaying
axis
#6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 59 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
e982570
Added first working version of sync axes
filipesantiagoAM b68537e
Null verification to the overlaying axis
filipesantiagoAM debd59b
added comments for readability
c3fcb6d
npm run schema
48e60c2
Merge branch 'plotly:master' into first_poc_tickmode_sync
fsantiago99 6a4a5ba
Removed math.abs() from prepTicks sync
filipesantiagoAM 76debab
Rename new tickmode sync mock to z-new_tickmode_sync
filipesantiagoAM 4ab851e
Add baseline image for new tickmode sync mock
filipesantiagoAM e983614
Fix mock-validation tests for z-new_tickmode_sync mock
filipesantiagoAM 6446faf
Merge branch 'first_poc_tickmode_sync' of https://github.com/VictorBe…
filipesantiagoAM e62be46
Remove unused tickmode sync mode to some plot types
filipesantiagoAM 93f4a8e
Moves tickmode sync to use last position on the grid
filipesantiagoAM 22c703a
Removed tickmode sync from non-relevant plot types
filipesantiagoAM 3fb6996
Updated tickmode test image baseline
filipesantiagoAM e4909bf
Merge remote-tracking branch 'origin/master' into first_poc_tickmode_…
filipesantiagoAM 7590ef8
Removed grid from the overlayed axis
filipesantiagoAM 3f5e118
Fixed baseline image for tickmode sync
filipesantiagoAM ed7b3ee
Merge branch 'first_poc_tickmode_sync' of https://github.com/VictorBe…
filipesantiagoAM 6352d93
Trigger Build
filipesantiagoAM b03faea
Moved tickmode sync logic to syncTicks
filipesantiagoAM b5e957b
Updated baseline image for z-new-tickmode-sync mock
filipesantiagoAM 6fd182c
Fix minor ticks for tickmode sync
filipesantiagoAM a4417a6
Update baseline image and revert lint fixes
filipesantiagoAM 8c25bf6
Fix lint errors
filipesantiagoAM 5d5c8da
Improved tickmode sync logic to round ticks
filipesantiagoAM bb3e7ae
Update baseline image for z-new_tickmode_sync
filipesantiagoAM 262141b
Sync overlayed axis when main axis redraw
filipesantiagoAM 92281af
Fix validation for redraw
filipesantiagoAM 5ad0185
Merge branch 'plotly:master' into first_poc_tickmode_sync
filipesantiagoAM 8ddfcc3
Reorder axes with dependency tickmode sync
filipesantiagoAM ea84512
Merge branch 'first_poc_tickmode_sync' of https://github.com/VictorBe…
filipesantiagoAM 434d703
Merge branch 'plotly:master' into first_poc_tickmode_sync
filipesantiagoAM 77dee05
Merge branch 'master' into first_poc_tickmode_sync
filipesantiagoAM 25d015c
Renamed sync axes function
filipesantiagoAM 0ff7ca5
Merge branch 'first_poc_tickmode_sync' of https://github.com/VictorBe…
filipesantiagoAM 3a87dd4
Add test for tickmode sync xAxes
filipesantiagoAM 179dd5b
Sync overlayed axis relayout
filipesantiagoAM a08766b
Update baseline image z-new_tickmode_sync
filipesantiagoAM 5afad5e
Remove unused tickmode sync logic
filipesantiagoAM 7a9f1e7
Reorder axes with dependency tickmode sync
filipesantiagoAM 16aa4be
Lint error fix
filipesantiagoAM 74509ef
Fix gridcolor for tickmode sync
filipesantiagoAM 43e17de
Update baseline image for tickmode sync
filipesantiagoAM 45616b4
z-new_tickmode_sync.json adjustments
filipesantiagoAM 30ebad1
Update baseline image for tickmode sync
filipesantiagoAM ac768c0
Ticks sync round improvement
filipesantiagoAM 3ca4aed
Improved ticks sync calculations
filipesantiagoAM f28ee6c
Reverted "Improved ticks sync calculations"
filipesantiagoAM 9dd3003
Update baseline image for tickmode sync
filipesantiagoAM 12ae78b
Merge branch 'first_poc_tickmode_sync' of https://github.com/VictorBe…
filipesantiagoAM 0e35a0f
Improve z-new_tickmode_sync.json
filipesantiagoAM 685bef6
Add grid to z-new_tickmode_sync.json
filipesantiagoAM 6c363ad
Update baseline image for tickmode sync
filipesantiagoAM fd78e8d
Removing tickmode sync from minor ticks
filipesantiagoAM 795350a
Update plot-schema without tickmode for minor axes
filipesantiagoAM 50165f6
Fix lint
filipesantiagoAM 04cc07e
Merge branch 'plotly:master' into first_poc_tickmode_sync
filipesantiagoAM 6e317d4
Improved tickmode schema declaration
filipesantiagoAM 196b7dd
Fix lint error
filipesantiagoAM 25e1389
added commit file to draftlogs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"name": "Apples", | ||
"type": "bar", | ||
"x": [ | ||
"2000-01", | ||
"2000-02", | ||
"2000-03", | ||
"2000-04", | ||
"2000-05" | ||
], | ||
"y": [ | ||
232, | ||
2506, | ||
470, | ||
1864, | ||
-190 | ||
] | ||
}, | ||
{ | ||
"name": "Oranges", | ||
"type": "scatter", | ||
"x": [ | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"A", | ||
"B", | ||
"C", | ||
"D", | ||
"E" | ||
], | ||
"y": [ | ||
0, | ||
0.4, | ||
0.1, | ||
0.3, | ||
0.2 | ||
], | ||
"yaxis": "y2", | ||
"xaxis": "x2" | ||
} | ||
], | ||
"layout": { | ||
"margin": { | ||
"t": 40, | ||
"r": 70, | ||
"b": 40, | ||
"l": 70 | ||
}, | ||
"width": 700, | ||
"showlegend": false, | ||
"xaxis": { | ||
"showgrid": true, | ||
"ticklen": 10, | ||
"tickwidth": 3, | ||
"ticklabelmode": "period" | ||
}, | ||
"xaxis2": { | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"anchor": "y2", | ||
"side": "top", | ||
"overlaying": "x", | ||
"tickmode": "sync", | ||
"ticklen": 10, | ||
"tickwidth": 3 | ||
}, | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"yaxis": { | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"title": { | ||
"text": "Apples" | ||
}, | ||
"side": "left", | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"range": [ | ||
0, | ||
2500 | ||
], | ||
"ticklen": 10, | ||
"tickwidth": 3, | ||
"minor": { | ||
"showgrid": true | ||
} | ||
}, | ||
"yaxis2": { | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"title": { | ||
"text": "Oranges" | ||
}, | ||
"side": "right", | ||
"range": [ | ||
0, | ||
0.5 | ||
], | ||
"ticklen": 10, | ||
"tickwidth": 3, | ||
"overlaying": "y", | ||
"tickmode": "sync", | ||
"minor": { | ||
"showgrid": true | ||
}, | ||
"zeroline": false | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.