Skip to content

add instruction for TypeScript usage #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Oct 4, 2019

No description provided.

@etpinard
Copy link
Contributor

etpinard commented Oct 4, 2019

First off, thanks for the PR!

Hmm, I'm not 100% sure we should include this in our Readme as we have no control over the typescript definitions (cf #28).

Furthermore, no current plotly.js team member has any experience using typescript, so we can't really put our stamp-of-approval on them.

At the very least, I don't think we should include typescript info in the "Quick start options" section. Personally, I think this belongs in a new section below "Building plotly.js".

cc @plotly/plotly_js @nicolaskruchten

@nicolaskruchten
Copy link
Contributor

We could add a section that says something like "Related third-party projects" or something and list the TS thing there? I agree we don't want to stamp our approval to the TS typings at this time, not because they're bad, but because we can't commit to maintaining them.

@simon04
Copy link
Contributor Author

simon04 commented Oct 7, 2019

Thank you, @etpinard and @nicolaskruchten, for your review and comments. I agree that having a separate section for 3rd party contribution is more adequate, and addressed this in the commit f5e3329.

@archmoj
Copy link
Contributor

archmoj commented Jun 3, 2020

@simon04 could you please merge master into this branch and resolve the conflict?

@archmoj archmoj added status: in progress community community contribution labels Jun 5, 2020
@gvwilson gvwilson self-assigned this Jun 10, 2024
@gvwilson
Copy link
Contributor

This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson

@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson changed the title README: add instruction for TypeScript usage add instruction for TypeScript usage Aug 8, 2024
@gvwilson gvwilson added infrastructure build process etc. feature something new P2 considered for next cycle and removed type: documentation labels Aug 8, 2024
@ndrezn ndrezn closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new infrastructure build process etc. P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants