-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Funnelarea traces #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Funnelarea traces #3876
Changes from 22 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
d77474e
add funnelarea to lib components plot api etc
archmoj 2d090d1
refactor other traces to reuse code in funnelarea
archmoj 7b0e602
add funnelarea trace code
archmoj 1b8caed
add funnelarea jasmine and image tests
archmoj 32b7b0b
correct groupscale in various dim ratios
archmoj 68bebc2
Merge branch 'master' into funnelarea-traces
etpinard 7c3369b
rm 'i' & 'v' from funnelarea event data
etpinard abc3b39
revise hiddenlabels coerce - rm hiddenLabels unused category - rm _ha…
archmoj 316aff9
more explicit funnelarea marker line color - dont inherit from sunburst
archmoj 7f2dc2a
drop round stroke line join
archmoj 7e6b9ae
drop quadrants and move func from funnelarea plot - add todo comment …
archmoj 8bd1875
default funnelarea textinfo to percent not value
archmoj fa5b273
move convexPolygonArea to funnelarea_test - add another set of tests …
archmoj 38b474d
revise funnelarea title attribute - drop support for old API
archmoj de8b517
add mock light and dark colorways for pie and funnelarea
archmoj a6a6d62
drop sort from one jasmine mock
archmoj 42ca38e
moduleHasUnSelected > moduleHasUnselected
archmoj 32c96d2
no need to outsidetextfont attribute in funnelarea
archmoj 2ad1843
fixup name of funnelarea mock used in mock list
etpinard 8af4d12
add textposition inside none - change pie title and textposition edit…
archmoj 4711c5c
Merge branch 'funnelarea-traces' into funnelarea-traces_dev
archmoj a9625b6
drop funnelarea sort - auto sort when funnelarea is aggregated - fixu…
archmoj 1426be7
Merge branch 'master' into funnelarea-traces
etpinard 79415cd
use trace._meta for funnelarea title.text
etpinard e227763
remove outsudetext from funnelarea mock
archmoj 04b14a8
clear TODO comment for hiddenlabels role
archmoj 4d89d1d
apply domain width and height with aspectratio
archmoj 23bc199
add delay between sort-by-value tests
etpinard dd673a2
add test for pie title.position restyle calls
etpinard 6673fac
:hocho: "TODO: test" for attrs that already have sufficient coverage
etpinard c64fe84
drop @flaky on @noCI test
etpinard 77f1c59
drop @noCI on funnel & waterfall select tests
etpinard 28b2f14
improve funnelarea scalegroup
archmoj c42a899
add shapes around domain boxes in funnelarea mocks
archmoj 84b0dd1
flip processing aspectratio
archmoj 08a1f7b
remove unused mock
archmoj b8b3d94
fit r using trace.aspectratio when having non scalegroup
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright 2012-2019, Plotly, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
module.exports = require('../src/traces/funnelarea'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.