Skip to content

Fix for number 0 treated as invalid in hover (#1) #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Fix for number 0 treated as invalid in hover (#1) #2682

merged 1 commit into from
May 30, 2018

Conversation

dalle
Copy link
Contributor

@dalle dalle commented May 30, 2018

@dalle
Fix for number 0 treated as invalid in hover (#1)
1113e33 
* treat zero as valid fixes plotly#2660

* PR suggestions: toBe instead of toEqual
@alexcjohnson
Copy link
Collaborator

Thanks @dalle - looks perfect! 💃

@alexcjohnson alexcjohnson merged commit 253212d into plotly:master May 30, 2018
@etpinard
Copy link
Contributor

sweet PR @dalle thanks very much 🎉

@etpinard etpinard added the bug something broken label May 30, 2018
@dalle
Copy link
Contributor Author

dalle commented May 30, 2018

@alexcjohnson @etpinard Thank you for all the praise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip text not working when text is 0 (number)
3 participants
@dalle @alexcjohnson @etpinard